Project

General

Profile

Bug #1337

Skråstreg/slash-tegn i (typisk) periodica-poster forhindrer reservering

Added by Niels Frandsen about 4 years ago. Updated over 3 years ago.

Status:
Resolved (tag version)
Priority:
Urgent
Assignee:
Estimated time:
URL med eksempel:
Kategorier:
Søgning - Materialevisning, Integration - DDELibra

Description

Vi har konstateret, at skråstreg/slashtegn i nr.-angivelsen i den bibliografiske post forhindrer reserveringsmulighed (se vedhæftede)

History

#1 Updated by Rolf Madsen about 4 years ago

  • Status changed from New to Open (waiting)
  • Priority changed from Normal to Urgent
  • Target version set to DDB CMS 2015 4. opgradering

#2 Updated by Jørgen Nielsen about 4 years ago

  • Assignee set to Gitte Barlach

Elektor er ikke i AAKB's base. Er der en post hos AAKB, som har et lignende nummer? ("May-June" eller andet med bindestreg)

#3 Updated by Rolf Madsen about 4 years ago

  • Target version changed from DDB CMS 2015 4. opgradering to 35

#4 Updated by Rolf Madsen about 4 years ago

  • Target version changed from 35 to 36

#5 Updated by Gitte Barlach about 4 years ago

  • Assignee changed from Gitte Barlach to Martin Cording

Hermed et eksempel fra Aarhus:

https://www.aakb.dk/ting/object/870970-basis%3A49401841

Juni/Juli, Nr. 006/007

#6 Updated by Martin Cording about 4 years ago

https://github.com/ding2/ding_periodical/pull/6

There is still an issue here, but it only persist with periodicals which has the ampersand (&) within its name.
We have tried everything we could, but we were not able to make the reservation (directly in the WS).

This is an example of a holding from ALMA:
<holding *reservable="04538285ZXNo. 464/465ZXVol. 41ZX2015ZXZX"* status="referenceOnly" nofOrdered="0" nofCheckedOut="0" nofReference="1" nofTotal="1" collectionId="nyeste" subLocationId="" locationId="tidsskri" departmentId="vo" branchId="skb" organisationId="DK-774600" showReservationButton="yes" nofAvailableForLoan="0" shelfMark="62.3605 > Elektor"/>

The reserve parameter is used to make the reservation to alma/patron/reservations/add and all is good with the pull request above.

However a holding with the ampersand included will not work, eg.:
<holding *reservable="04538285ZXNo. 460 & 461ZXVol. 40ZX2015ZXZX"* status="availableForLoan" nofOrdered="0" nofCheckedOut="0" nofReference="0" nofTotal="1" collectionId="14dag" subLocationId="" locationId="tidsskri" departmentId="vo" branchId="skb" organisationId="DK-774600" showReservationButton="yes" nofAvailableForLoan="1" shelfMark="62.3605 > Elektor"/>

Unless anyone has a proposal, I suggest that Axiell gets this request.
How to make a reservation to an item like this?

#7 Updated by Gitte Barlach about 4 years ago

  • Status changed from Open (waiting) to Needs code review
  • Assignee changed from Martin Cording to Jesper Kristensen

#8 Updated by Steen Larsen about 4 years ago

Hvis man encoder 2 gange ser det ud til at virke

F.eks.

<compositeHolding status="availableForLoan" value="Sund & Slank, 42#">
<holdings>
<holding reservable="06373674ZX42#ZXSund & SlankZX2004ZXZX" status="availableForLoan" .../>
</holdings>
</compositeHolding>

hvor reservable i selve kaldet til alma bliver til 06373674ZX42%2523ZXSund%2520%2526%2520SlankZX2004ZXZX

#9 Updated by Jesper Kristensen about 4 years ago

  • Status changed from Needs code review to Ready for development
  • Assignee changed from Jesper Kristensen to Gitte Barlach

#10 Updated by Martin Cording about 4 years ago

  • Assignee changed from Gitte Barlach to Martin Cording

#11 Updated by Martin Cording about 4 years ago

  • Status changed from Ready for development to Needs code review
  • Assignee changed from Martin Cording to Jesper Kristensen

PR has been updated.

/cc @Steen

#12 Updated by Kasper Garnæs almost 4 years ago

  • Assignee changed from Jesper Kristensen to Martin Cording

Jeg har reviewet rettelsen og har et par kommentarer.

#13 Updated by Kasper Garnæs almost 4 years ago

  • Status changed from Needs code review to Development

#14 Updated by Martin Cording almost 4 years ago

  • Assignee changed from Martin Cording to Kasper Garnæs

#15 Updated by Kasper Garnæs almost 4 years ago

  • Assignee changed from Kasper Garnæs to Martin Cording

#16 Updated by Rolf Madsen almost 4 years ago

  • Target version changed from 36 to DDB CMS 2015 4. opgradering

#17 Updated by Martin Cording almost 4 years ago

  • Status changed from Development to Needs code review
  • Assignee changed from Martin Cording to Kasper Garnæs

Pull Request updated and https://github.com/ding2/alma/pull/21 added.

#18 Updated by Kasper Garnæs almost 4 years ago

  • Assignee changed from Kasper Garnæs to Martin Cording

Alma ændringen er godkendt. Jeg har kommenteret på det originale pull request.

#19 Updated by Gitte Barlach almost 4 years ago

  • Status changed from Needs code review to Ready for development

#20 Updated by Martin Cording almost 4 years ago

  • Status changed from Ready for development to Needs code review
  • Assignee changed from Martin Cording to Kasper Garnæs

#21 Updated by Kasper Garnæs almost 4 years ago

  • Status changed from Needs code review to Technical test
  • Assignee changed from Kasper Garnæs to Gitte Barlach

Reviewed og godkendt.

#22 Updated by Gitte Barlach almost 4 years ago

Testet på vanilla alma med dette tidskrift:
https://upgrade-alma.ddbcms.dk/ting/object/870970-basis%3A49401841

Det er desværre stadig ikke muligt at reservere Juni/Juli, Nr. 006/007 - se vedhæftede skærmdump
Ved de numre som jeg faktisk kan reservere (dem uden /) er encodningen af & i tidsskriftets titel på reserveringsbekræftelsen ikke korrekt. Se vedhæftede skærmdump

#23 Updated by Rolf Madsen almost 4 years ago

  • Target version changed from DDB CMS 2015 4. opgradering to DDB CMS 2016 1. opgradering

#24 Updated by Steen Larsen almost 4 years ago

Må være samme problematik som ved Femina 2015 - faust 03200442 hvor der er tidsskriftsnumre med #

#25 Updated by Martin Cording almost 4 years ago

Are you sure that it has been merged and deployed correctly?

#26 Updated by Kasper Garnæs almost 4 years ago

  • Status changed from Reviewed - Needs info/rework to Reviewed
  • Assignee changed from Rolf Madsen to Gitte Barlach

Martin: Pull requests'ne er ikke blevet merged korrekt. Jeg kan ikke findes referencer til Issue 1337 i historikken.

Gitte: Skal dette ind som et hotfix til 2.4.0?

#27 Updated by Gitte Barlach over 3 years ago

  • Assignee changed from Gitte Barlach to Kasper Garnæs

@Kasper: det vil være godt at at få det med om hotfix; jeg formoder det er en simpel/enkel rettelse, der ikke berører andre dele af kodebasen.

#28 Updated by Tina Skjærbæk Søeborg over 3 years ago

Denne rettelse virker ikke i 2.4.0 på https://hvidovre-stg.ddbcms.dk/

Testet med dette objekt
https://hvidovre-stg.ddbcms.dk/ting/object/870970-basis%3A49408625

Jeg får den omtalte fejl, når jeg klikker på 2015 > 06/07 og derefter klikker på "Reserver"

Fejlen forekommer ikke ved klik på 2015 > 08 eller på 2015 > 05

#29 Updated by Niels Frandsen over 3 years ago

Det virker på Ballerup staging site (testet med oprindeligt eksempel "Elektor Electronics")

#30 Updated by Niels Frandsen over 3 years ago

Ups! Beklager... For hurtig testning: Det virker heller IKKE i Ballerup!

#31 Updated by Gitte Barlach over 3 years ago

Hej Niels og Tina
Tak for test. Som Kasper gør opmærksom på så er pull requests'ne er ikke blevet merged korrekt, og derfor virker rettelsen ikke i release 2.4.0;

#32 Updated by Gitte Barlach over 3 years ago

Denne gang merged korrekt (i rel. 2.4.2.)
Testet på vanilla-upgrade.

Jeg får stadig samme fejl som tidl.:

Når jeg vil reservere tidsskriftet "Lyd & billede + Gear : Nordens største magasin om gadgets og forbrugerelektronik!" - nr. Juni/Juli, Nr. 006/007 får jeg flg. fejl.medd.:
"Lyd & billede + Gear : Nordens største magasin om gadgets og forbrugerelektronik!, årgang 007ZXJuni, nummer JuliZX2013ZXZX" is not available for reservation."

#33 Updated by Gitte Barlach over 3 years ago

  • Assignee changed from Kasper Garnæs to Rolf Madsen

#34 Updated by Gitte Barlach over 3 years ago

  • Status changed from Reviewed to Technical test

#35 Updated by Rolf Madsen over 3 years ago

  • Assignee changed from Rolf Madsen to Gitte Barlach

#36 Updated by Martin Cording over 3 years ago

Is this something we should look at? 100% sure it's merged correct? :)

#38 Updated by Martin Cording over 3 years ago

I'm not sure I understand you - all these commits are merged into core since 7.x-2.4.2: https://github.com/ding2/ding2/compare/7.x-2.4.1...7.x-2.4.2.

They correspond to the changes in the original Pull Request.

#39 Updated by Gitte Barlach over 3 years ago

Testet på vanilla-alma.

Jeg kan nu reservere en post med Skråstreg/slash-tegn i titlen.

(testet reservering af "Lyd & billede + Gear : Nordens største magasin om gadgets og forbrugerelektronik!" - nr. Juni/Juli, Nr. 006/007" samt "Haven" - 2013, 113. Årg., 1/2)

Der bør dog rettes en mindre fejl i encodingen i reserveringsbekræftelsen - se vedhæftede skærmdump

#40 Updated by Gitte Barlach over 3 years ago

Testet på vanilla og upgradeOpenRuth og OK.

testcases:

Lyd & billede. 2013, 06/07
Haven. 2016, 01/02
Motor. 2015, 07/08

#41 Updated by Gitte Barlach over 3 years ago

Har oprettet en ny sag ift. encoding-fejlen: #1629

#42 Updated by Gitte Barlach over 3 years ago

  • Status changed from Technical test to Resolved (tag version)

#43 Updated by Rolf Madsen over 3 years ago

  • Kategorier Søgning - Materialevisning, Integration - DDELibra added

Also available in: Atom PDF