Project

General

Profile

Bug #2983

Søgecirklen mangler i Explorer

Added by Tue Gaston almost 2 years ago. Updated about 1 year ago.

Status:
Reviewed - Needs info/rework
Priority:
Normal
Assignee:
Target version:
Estimated time:
URL med eksempel:
Kategorier:
Søgning - Søgefelt før søg - Brønd

Description

"Søgecirklen" (altså denne her:)

Mangler nogle gange i Explorer 11 - andre gange er den der, men kører ikke rundt.

image001.jpg (78.9 KB) image001.jpg Gitte Barlach, 01/25/2018 04:02 PM

History

#1 Updated by Rolf Madsen almost 2 years ago

  • Status changed from New to Ready for development
  • Assignee set to Kristian Pedersen
  • Target version set to Release 27 - Bugfixes (2017 2. opgradering) (7.x-4.2.1)

#2 Updated by Rasmus Høymann Laursen almost 2 years ago

  • Assignee changed from Kristian Pedersen to Steen Holten-Andersen

#3 Updated by Steen Holten-Andersen almost 2 years ago

  • Status changed from Ready for development to Needs code review
  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

PR: https://github.com/ding2/ding2/pull/849

Kunne ikke genskabe lokalt i IE 11, men IE 10 viste ikke spinner-circlen når søgning skete vha. tryk på enter. Dette er løst i dette PR.

Hvis denne PR ikke løser det komplette issue (IE11), bedes venligst om lidt mere uddybning af problemet. Hvornår opstår det? Er det både ved tryk på 'Søg' og søgning ved tryk på 'Enter'.

#4 Updated by Gitte Barlach almost 2 years ago

  • Assignee changed from Gitte Barlach to Jette Nielsen

#5 Updated by Rolf Madsen almost 2 years ago

  • Assignee changed from Jette Nielsen to Steen Holten-Andersen

Cirklen mangler både ved tryk på enter og søg knappen.

Hvis du har brug for andre oplysninger så skriv hvad du skal bruge!

Windows Internet Explorer 11 version:

Screenshot:

#6 Updated by Steen Holten-Andersen almost 2 years ago

  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

PR: https://github.com/ding2/ding2/pull/855

PR updated after new info.

Problem seems to be that search-overlay is appended to the dom - and therefore on slower connections, the spinner.png is not properly loaded before the search is executed. The spinner.png image has been replaced by an inline svg - and the sorts the problem.

Has been tested locally on Chrome, FF, Safari, IE 10 and IE 11.

#7 Updated by Steen Holten-Andersen almost 2 years ago

  • Assignee changed from Gitte Barlach to Steen Holten-Andersen

Se bort fra tidligere kommentar og PR.

#8 Updated by Steen Holten-Andersen almost 2 years ago

  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

PR: https://github.com/ding2/ding2/pull/849 (https://github.com/ding2/ding2/pull/849/commits/5a47a676c94ca767d22cb27938795c1ab49ead5b)

PR updated after new info.

Problem seems to be that search-overlay is appended to the dom - and therefore on slower connections, the spinner.png is not properly loaded before the search is executed. The spinner.png image has been replaced by an inline svg - and the sorts the problem.

Has been tested locally on Chrome, FF, Safari, IE 10 and IE 11.

#9 Updated by Gitte Barlach almost 2 years ago

  • Assignee changed from Gitte Barlach to Jørgen Nielsen

#10 Updated by Jørgen Nielsen almost 2 years ago

  • Status changed from Needs code review to Reviewed
  • Assignee changed from Jørgen Nielsen to Gitte Barlach

reviewet og godkendt

#11 Updated by Kasper Garnæs almost 2 years ago

  • Status changed from Reviewed to Technical test

Merged.

#12 Updated by Michael W. Christoffersen almost 2 years ago

  • Status changed from Technical test to Reviewed - Needs info/rework
  • Assignee changed from Gitte Barlach to Steen Holten-Andersen

Virker fint i Chrome og FireFox (sidste både Windows og Mac), men ikke IE (Windows) og Safari (Mac). Samme netværk.

#13 Updated by Steen Holten-Andersen almost 2 years ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

#14 Updated by Gitte Barlach almost 2 years ago

  • Assignee changed from Gitte Barlach to Jesper Kristensen

#15 Updated by Jesper Kristensen almost 2 years ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Jesper Kristensen to Steen Holten-Andersen


Dette PR indholder osse rettelse til #3119 hvilket den ikke skal.

Det var et par enkelt kommentar til koden omkring #2983.

#16 Updated by Steen Holten-Andersen almost 2 years ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Steen Holten-Andersen to Jesper Kristensen

New PR: https://github.com/ding2/ding2/pull/934

Forget last PR.

#17 Updated by Jesper Kristensen over 1 year ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Jesper Kristensen to Steen Holten-Andersen

Indention i JS ser forket ud.

#18 Updated by Steen Holten-Andersen over 1 year ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Steen Holten-Andersen to Jesper Kristensen

#19 Updated by Jesper Kristensen over 1 year ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Jesper Kristensen to Steen Holten-Andersen

Indention i JS ser forket ud endnu.

#20 Updated by Steen Holten-Andersen over 1 year ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Steen Holten-Andersen to Jesper Kristensen

#21 Updated by Jesper Kristensen over 1 year ago

  • Status changed from Needs code review to Technical test
  • Assignee changed from Jesper Kristensen to Gitte Barlach


Merged

#22 Updated by Gitte Barlach over 1 year ago

  • File image001.jpg image001.jpg added
  • Status changed from Technical test to Reviewed - Needs info/rework
  • Assignee changed from Gitte Barlach to Steen Holten-Andersen

upgrade-fbs med 4.2.0-RC3

Har testet med Explorer 11.192.16299.0

Søgecirklen vises ikke

#23 Updated by Kasper Garnæs over 1 year ago

  • Status changed from Reviewed - Needs info/rework to Development
  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

Dette ticket er blevet trukket ud af release 27 og de kodemæssige ændringer er rullet tilbage: https://github.com/ding2/ding2/pull/987.

#24 Updated by Rolf Madsen over 1 year ago

  • Target version changed from Release 27 - Bugfixes (2017 2. opgradering) (7.x-4.2.1) to Release 29-2 - Bugfixes (7.x-4.5.0)

#25 Updated by Gitte Barlach over 1 year ago

  • Status changed from Development to Reviewed - Needs info/rework
  • Assignee changed from Gitte Barlach to Steen Holten-Andersen

Hej Steen

Kan I kigge på denne igen?

#26 Updated by Gitte Barlach over 1 year ago

  • Status changed from Reviewed - Needs info/rework to Development

#27 Updated by Rolf Madsen over 1 year ago

  • Target version changed from Release 29-2 - Bugfixes (7.x-4.5.0) to Release 29-2 - Bugfixes (B14)

#28 Updated by Steen Holten-Andersen over 1 year ago

  • Status changed from Development to Need more info
  • Assignee changed from Steen Holten-Andersen to Gitte Barlach

Hej Gitte.

Med det sidste PR: https://github.com/ding2/ding2/pull/934 - kan vi ikke genskabe lokalt.

Vi har testet følgende:

macOS 10.13.3:

Chrome: 64.0.3282.186

FireFox: 58.0.2

Safari: 11.0.3

VirtualMachine Win7:

IE 11 - 11.0.9600.17914

IE 10 - 10.0.9200.17609

Native Windows maskine:

IE 11 - 11.248.16299.0

-----

Gitte - jeg sender lige link til min lokale installation som er testet, for at se om du også oplever problemer på den, eller om det ligger i FBS installationen.

 

#29 Updated by Rolf Madsen over 1 year ago

  • Target version changed from Release 29-2 - Bugfixes (B14) to Release 33 - Bugfixes

#30 Updated by Rolf Madsen about 1 year ago

  • Status changed from Need more info to Reviewed - Needs info/rework

Also available in: Atom PDF