Project

General

Profile

Bug #3017

Rettelser til /admin/config/ting/ siderne efter ændring af sort random i Databrønden / Opensearch

Added by Thomas Hansen over 2 years ago. Updated about 1 year ago.

Status:
Resolved (tag version)
Priority:
Normal
Assignee:
Estimated time:
URL med eksempel:
Kategorier:
Administration - Systemkonfiguration, Integration - Brønd - Data og relationer

Description

Det gælder ihvertfald https://opensearch.addi.dk/b3.5_4.5/ 

Det sted jeg er rendt ind i problemet er ting administrations siderne hvor den henter lister af materiale typer og kilder for at man f.eks. kan konfigurere hvilke typer der er reserverbare.

Den hurtige fiks er at fjerne "'sort' => 'random'," i _ting_fetch_well_types() og _ting_fetch_well_sources(), det er ikke så vigtigt (jeg burde vide det, det er min kode).

 

History

#2 Updated by Gitte Barlach over 2 years ago

  • Status changed from New to Needs code review
  • Assignee set to Jørgen Nielsen
  • Target version set to Release 27 - Bugfixes (2017 2. opgradering) (7.x-4.2.1)

#3 Updated by Rolf Madsen over 2 years ago

Request

<?xml version="1.0" encoding="UTF-8"?>
<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:ns1="http://oss.dbc.dk/ns/opensearch">
  <SOAP-ENV:Body>
    <ns1:searchRequest>
      <ns1:query>"John Ajvide Lindqvist"</ns1:query>
      <ns1:agency>100200</ns1:agency>
      <ns1:profile>test</ns1:profile>
      <ns1:collectionType>manifestation</ns1:collectionType>
      <ns1:start>1</ns1:start>
      <ns1:stepValue>10</ns1:stepValue>
      <ns1:sort>random</ns1:sort>
    </ns1:searchRequest>
  </SOAP-ENV:Body>
</SOAP-ENV:Envelope>

Response:

Denne side virker ikke

opensearch.addi.dk kan i øjeblikket ikke behandle denne anmodning.

HTTP ERROR 500

#4 Updated by Rolf Madsen over 2 years ago

Ville det ikke være mere korrekt at få rettet fejlen i Opensearch?

#5 Updated by Rolf Madsen over 2 years ago

  • Status changed from Needs code review to DBC (waiting)
  • Assignee deleted (Jørgen Nielsen)

Jeg har oprettet sagsnummer Din sag har fået nummer: 65977 hos DBC.

#6 Updated by Rolf Madsen over 2 years ago

  • Status changed from DBC (waiting) to Resolved

DBC har lavet en rettelse så sort fungerer igen, blot ikke random.

#7 Updated by Kasper Garnæs about 2 years ago

  • Assignee set to Rolf Madsen

Ændringerne her er stadig relevante. Den konkrete fejl er blevet rettet i #3126, men deruodver indholder Thomas også en række mindre stilmæssige refaktoreringer til Ting-modulet.

Derfor foreslår jeg at denne bliver genåbnet med en ny overskrift.

#8 Updated by Rolf Madsen about 2 years ago

  • Subject changed from Brønden kan ikke lide random order to Rettelser til /admin/config/ting/ siderne efter ændring af sort random i Databrønden / Opensearch

Tak for heads-up!

Jeg har givet et bud på ny titel, men ret gerne til.

#9 Updated by Rolf Madsen about 2 years ago

  • Status changed from Resolved to Needs code review
  • Assignee changed from Rolf Madsen to Gitte Barlach

#10 Updated by Gitte Barlach about 2 years ago

  • Assignee changed from Gitte Barlach to Jesper Kristensen

#11 Updated by Jesper Kristensen about 2 years ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Jesper Kristensen to Thomas Hansen

Der var lige en enklet kommentar i forhold til ændring af permission også skal den lige rebases for at kan merges.

#12 Updated by Thomas Hansen about 2 years ago

done

#13 Updated by Christel Krabbenhøft about 2 years ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Thomas Hansen to Jesper Kristensen

#14 Updated by Christel Krabbenhøft about 2 years ago

  • Target version changed from Release 27 - Bugfixes (2017 2. opgradering) (7.x-4.2.1) to Release 29-2 - Bugfixes (7.x-4.5.0)

#15 Updated by Jørgen Nielsen almost 2 years ago

  • Assignee changed from Jesper Kristensen to Jørgen Nielsen

#16 Updated by Jørgen Nielsen over 1 year ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Jørgen Nielsen to Thomas Hansen

Der er en merge konflikt, der skal tages hånd om - kan du rebase?

#17 Updated by Christel Krabbenhøft over 1 year ago

  • Target version changed from Release 29-2 - Bugfixes (7.x-4.5.0) to Release 30 - BPI, Kampagneplus og Sektioner - (Reload)

#18 Updated by Stefan Søndervang over 1 year ago

@Thomas. Kan du kigge på rebasen?

#19 Updated by Thomas Hansen about 1 year ago

Det var fandme besværligt, men der er et nyt PR i https://github.com/ding2/ding2/pull/1282

#20 Updated by Christel Krabbenhøft about 1 year ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Thomas Hansen to Jørgen Nielsen

#21 Updated by Jørgen Nielsen about 1 year ago

  • Status changed from Needs code review to Reviewed
  • Assignee changed from Jørgen Nielsen to Gitte Barlach

reviewet og godkendt

#22 Updated by Kasper Garnæs about 1 year ago

  • Status changed from Reviewed to Technical test

Merged.

#23 Updated by Gitte Barlach about 1 year ago

  • Status changed from Technical test to Resolved (tag version)

Testet på upgrade-fbs med 4.6.0-rc4
 

Jeg har testet at man kan klikke på "update" og hente lister af materiale typer og kilder i backend her:

/admin/config/ting/holdings
/admin/config/ting/online_types

Jeg er i tvivl om hvad der helt præcist menes med "deruodver indholder Thomas også en række mindre stilmæssige refaktoreringer til Ting-modulet."

Trods det lille forbehold vælger jeg at godkende sagen. 

Also available in: Atom PDF