Project

General

Profile

Bug #4153

Styling: Streger under tekst i dialogfelt

Added by Nino Tiainen about 1 year ago. Updated 4 months ago.

Status:
Needs code review
Priority:
Normal
Assignee:
Target version:
Estimated time:
URL med eksempel:
Kategorier:
Søgning - Søgeresultat efter søg - Brønd

Description

Se vedhæftede. Umiddelbart ligner det en lille stylingfelt. Andre dialogbokse vises ikke tilsvarende understregning. 

2019-02-18_11-07-54.png (393 KB) 2019-02-18_11-07-54.png Nino Tiainen, 02/18/2019 11:14 AM

History

#1 Updated by Christel Krabbenhøft about 1 year ago

  • Subject changed from Styling: Streger under tekst i dialogfelt. to Styling: Streger under tekst i dialogfelt
  • Status changed from New to Need more info
  • Assignee set to Rasmus Høymann Laursen

Hej Rasmus. Vil du uddybe valget af understregning?

#2 Updated by Christel Krabbenhøft about 1 year ago

  • Target version set to Release 31 - bugfixes (B14)

#3 Updated by Rasmus Høymann Laursen about 1 year ago

  • Assignee changed from Rasmus Høymann Laursen to Christel Krabbenhøft

Det har jeg desværre ikke noget godt bud på. Skal vi ikke fjerne disse?

#4 Updated by Christel Krabbenhøft about 1 year ago

  • Status changed from Need more info to Ready for development
  • Assignee changed from Christel Krabbenhøft to Rasmus Høymann Laursen

Hej Rasmus. Jo - gerne:)

#5 Updated by Rasmus Høymann Laursen about 1 year ago

  • Assignee changed from Rasmus Høymann Laursen to Steen Holten-Andersen

#6 Updated by Steen Holten-Andersen about 1 year ago

  • Status changed from Ready for development to Needs code review
  • Assignee changed from Steen Holten-Andersen to Christel Krabbenhøft

PR: https://github.com/ding2/ding2/pull/1374

Commit fejler test i Circle-CI: https://circleci.com/gh/ding2/ding2/5048?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link 
Da PR er ekstremt simpelt (én enkelte ændring i SASS), og lavet på en helt ny rebased installation - tænker jeg at fejlen må skyldes en fejl i Circle-CI. Kan Core bekræfte/afkræfte dette?

#7 Updated by Christel Krabbenhøft about 1 year ago

  • Assignee changed from Christel Krabbenhøft to Gitte Barlach

#8 Updated by Gitte Barlach 10 months ago

  • Assignee changed from Gitte Barlach to Jørgen Nielsen

#9 Updated by Jørgen Nielsen 5 months ago

reviewet og godkendt
- det er næppe værd at bruge krudt på Circle-CI

#10 Updated by Jørgen Nielsen 5 months ago

  • Status changed from Needs code review to Reviewed
  • Assignee changed from Jørgen Nielsen to Gitte Barlach

#11 Updated by Kasper Garnæs 5 months ago

  • Status changed from Reviewed to Technical test
  • Assignee changed from Gitte Barlach to Kasper Garnæs

Merged.

#12 Updated by Nhi A Sy 5 months ago

  • Assignee changed from Kasper Garnæs to Rasmus Høymann Laursen

Testet på Upgrade (ding2-7.x-5.0.0-beta5)

Understregning er stadig i popup bekræftelsen ved reserveringen af et materiale.

#13 Updated by Nhi A Sy 5 months ago

  • Status changed from Technical test to Needs code review

#14 Updated by Rasmus Høymann Laursen 5 months ago

  • Assignee changed from Rasmus Høymann Laursen to Steen Holten-Andersen

#15 Updated by Christel Krabbenhøft 5 months ago

  • Status changed from Needs code review to Reviewed - Needs info/rework

#16 Updated by Gitte Barlach 4 months ago

  • Target version changed from Release 31 - bugfixes (B14) to Release 32 - Bugfixes

#17 Updated by Steen Holten-Andersen 4 months ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Steen Holten-Andersen to Christel Krabbenhøft

Nyt PR: https://github.com/ding2/ding2/pull/1555

Fejler på CircleCI: Bhat tests, men commit indeholder udelukkende en slettet linje i en scss fil.

#18 Updated by Christel Krabbenhøft 4 months ago

  • Assignee changed from Christel Krabbenhøft to Gitte Barlach

Also available in: Atom PDF