Project

General

Profile

Enhancement #4445

Kampagne PLUS: Fjernelse af feltet "Tracking tags"

Added by Tue Gaston 4 months ago. Updated 2 months ago.

Status:
Resolved (tag version)
Priority:
Normal
Assignee:
Target version:
Estimated time:
URL med eksempel:
Kategorier:
Inspiration - Kampagner

Description

Eftersom det nu er afdækket, at der ikke er behov for at navngive tags separat, da kampagne-tracking fuldt lige så effektivt kan ske ved tracking af kampagnens titel, er det besluttet at fjerne feltet "Tracking tags" fra Webtrekk.


Related issues

Related to DDB CMS - Enhancement #4443: Ændring af beskrivelse i Kampagne PLUSClosed
Related to DDB CMS - Bug #3573: Kampagne PLUS : Muliggørelse af kampagne-trackingResolved (tag version)

History

#1 Updated by Tue Gaston 4 months ago

#2 Updated by Tue Gaston 4 months ago

  • Related to Bug #3573: Kampagne PLUS : Muliggørelse af kampagne-tracking added

#3 Updated by Simon Holt 4 months ago

  • Status changed from Ready for development to Needs code review
  • Assignee changed from Simon Holt to Tue Gaston

#4 Updated by Tue Gaston 3 months ago

  • Assignee changed from Tue Gaston to Gitte Barlach

#5 Updated by Gitte Barlach 3 months ago

  • Assignee changed from Gitte Barlach to Kasper Garnæs

#6 Updated by Kasper Garnæs 3 months ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Kasper Garnæs to Simon Holt

Reviewed. Godt med simplificering og oprydning. Jeg har et enkelt spørgsmål.

#7 Updated by Simon Holt 3 months ago

  • Assignee changed from Simon Holt to Kasper Garnæs

Og det var et godt spørgsmål :) Har svaret på Github.

#8 Updated by Gitte Barlach 2 months ago

  • Status changed from Reviewed - Needs info/rework to Needs code review

#9 Updated by Kasper Garnæs 2 months ago

  • Status changed from Needs code review to Reviewed - Needs info/rework
  • Assignee changed from Kasper Garnæs to Simon Holt

Simon: Jeg har fuldt op på spørgsmålet.

PR'et kan ikke længere applies. Kan du rebase?

 

#10 Updated by Christel Krabbenhøft 2 months ago

Hej Simon. Kan du mon nå at rebase i dag? Så kan vi nemlig få rettelsen med i næste byg:-)

#11 Updated by Simon Holt 2 months ago

Hej Christel, Jeps er ved at kigge på den nu. Og denne her også: https://platform.dandigbib.org/issues/4399

#12 Updated by Simon Holt 2 months ago

  • Status changed from Reviewed - Needs info/rework to Needs code review
  • Assignee changed from Simon Holt to Gitte Barlach

PR er rebased og opdateret ift kommentar: https://github.com/ding2/ding2/pull/1492

#13 Updated by Gitte Barlach 2 months ago

  • Assignee changed from Gitte Barlach to Kasper Garnæs

#14 Updated by Kasper Garnæs 2 months ago

  • Status changed from Needs code review to Reviewed

Reviewed og godkendt.

#15 Updated by Kasper Garnæs 2 months ago

  • Status changed from Reviewed to Technical test

Merged.

#16 Updated by Tue Gaston 2 months ago

  • Status changed from Technical test to Resolved (tag version)
  • Assignee changed from Kasper Garnæs to Gitte Barlach

#17 Updated by Tue Gaston 2 months ago

Testet og godkendt.

Also available in: Atom PDF